Skip to content

GitHub: Implemented changelog generation #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from

Conversation

scottgonzalez
Copy link
Member

I haven't tested this yet, but figured I'd push in case someone else gets around to testing before I do.

TODO:

  • Filter our PRs

@jzaefferer
Copy link
Member

Could you rebase this? The PR now seems to include a bunch of unrelated commits, e.g. adding cdn.js, which doesn't belong here.

@scottgonzalez
Copy link
Member Author

Rebased.

@jzaefferer
Copy link
Member

This currently fails with Error: Cannot find module 'github'. Will try again later and dig a bit.

@scottgonzalez
Copy link
Member Author

Oops, try changing https://github.com/jquery/jquery-release/pull/8/files#diff-8f83cf4e554cfef336da48f2169e3704R2 to require( "github-request" ).

@scottgonzalez
Copy link
Member Author

We need to filter out pull request which show up as issues through the API.

@gnarf
Copy link
Member

gnarf commented Dec 21, 2014

Going through some old pulls, is this dead or should we revive it?

@arschmitz
Copy link
Member

This is on me iv promised to test twice :-(

@scottgonzalez
Copy link
Member Author

It's definitely not ready to be merged. There are at least two issues that are documented in my last two comments.

@gnarf
Copy link
Member

gnarf commented Dec 22, 2014

@scottgonzalez : could you maybe edit the open issues into the main pull as * [ ] items to be checked off?

@scottgonzalez
Copy link
Member Author

Did a minor update and added the PR filtering to the main description. In case you can't tell, I haven't actually tested this, I've just been waiting for someone managing a project that uses GitHub to finish this. At this point, it won't rebase cleanly.

@dmethvin
Copy link
Member

dmethvin commented Jan 5, 2015

Pinging @timmywil, he's working on several build-related tasks for our next release.

@scottgonzalez
Copy link
Member Author

I've rebased and mostly reimplemented this. It handles changelog generation, but not contributor gathering. This is ready for review now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

6 participants