-
Notifications
You must be signed in to change notification settings - Fork 31
GitHub: Implemented changelog generation #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Could you rebase this? The PR now seems to include a bunch of unrelated commits, e.g. adding cdn.js, which doesn't belong here. |
Rebased. |
This currently fails with |
Oops, try changing https://github.com/jquery/jquery-release/pull/8/files#diff-8f83cf4e554cfef336da48f2169e3704R2 to |
We need to filter out pull request which show up as issues through the API. |
Going through some old pulls, is this dead or should we revive it? |
This is on me iv promised to test twice :-( |
It's definitely not ready to be merged. There are at least two issues that are documented in my last two comments. |
@scottgonzalez : could you maybe edit the open issues into the main pull as |
Did a minor update and added the PR filtering to the main description. In case you can't tell, I haven't actually tested this, I've just been waiting for someone managing a project that uses GitHub to finish this. At this point, it won't rebase cleanly. |
Pinging @timmywil, he's working on several build-related tasks for our next release. |
Fixes gh-1
06c4e15
to
9da58a5
Compare
I've rebased and mostly reimplemented this. It handles changelog generation, but not contributor gathering. This is ready for review now. |
I haven't tested this yet, but figured I'd push in case someone else gets around to testing before I do.
TODO: