Clarify PhantomJS dependency

[NiGhTTraX]

Since PhantomJS is not in package.json, grunt relies on a globally installed version. Either clarify that in the documentation, or put PhantomJS in the dependencies. Running grunt without PhantomJS installed globally will result in a cryptic Error: spawn ENOENT.

I'll be happy to submit a pull request for either choice.

[jzaefferer]

This project depends on an old version of Grunt. Newer versions don't include the qunit-task anymore, and the new qunit-plugin actually bundles PhantomJS.

A PR to update to grunt 0.4.x and grunt-contribu-qunit would be very useful!

[NiGhTTraX]

Updated grunt to 0.4.1 and refactored the Gruntfile locally, but I have a couple of questions before I send in the pull request:

• The jshint target seems a bit complicated and unnecessary to me. The only thing it does is copy the keys from predefined to globals. Why not just edit the .jshintrc files to use globals in the first place and get rid of that function?
• Since grunt helpers were deprecated, I just turned the git-date helper into a regular function. Is that ok?

[scottgonzalez]

The predefined/globals munging is because old versions didn't support reading the .jshintrc file and you had to use different syntax for node and .jshintrc. This should all be squashed into a signle task like in jquery/jquery-ui/@61d16ec939c11f63419cae5bc2aa990134f6c0ff (but the name should be all, not src).

The git-date change sounds fine.

Thanks.

[NiGhTTraX]

Thanks for the reply.

Also, is the watch task still needed?

[scottgonzalez]

That'd be a question for @mikesherov. I never use watch tasks.

[NiGhTTraX]

Pull request here: #18

I left the watch target there in case someone needs it.

[mikesherov]

Yeah, thanks for contributing! The watch task is no longer needed. Can you remove that too and then I can land this?

[NiGhTTraX]

Sure thing. I created a var to hold the names of the files so I can pass them to the jshint and watch targets. Should I leave it like that or just squash them inside the jshint target?

[scottgonzalez]

I think either is fine.

[NiGhTTraX]

Alright, left the var there so it's easier to change the filenames in the future. Squashed and pushed.

[scottgonzalez]

Thanks!