Added HTML5 DND mouse events to regex #23
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks, but this is missing a CLA signatures and tests. Please read the contributing guidelines. |
Member
There was a problem hiding this comment.
Why is there a + in this regex?
Author
There was a problem hiding this comment.
good point, that was not in my original code. I had initially worked off an older version. when I decided to contribute this back I forked your project and tried to apply the changes to the new code base. I was at work and hurriedly applied the change to the fork and submitted. I apologize for that. However, I did make sure the change worked by rerunning my tests. I did not just fire and forget. I am willing to write tests and resubmit a cleaner pull request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used this to test my Angularjs DND directives. It works well. Thank you for the module.