Skip to content

Commit 1f9821c

Browse files
committed
Dialog: Remove animation stopping in destroy
Effects wrappers are no longer used, so the workaround and test are no longer necessary. This fixes tests in IE8 with jQuery 1.7. Effectively a complete revert of 13505e5 Closes gh-1481
1 parent a6a18d1 commit 1f9821c

File tree

3 files changed

+1
-11
lines changed

3 files changed

+1
-11
lines changed

tests/unit/dialog/dialog.html

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222
"ui/button.js",
2323
"ui/effect.js",
2424
"ui/effect-blind.js",
25-
"ui/effect-clip.js",
2625
"ui/effect-explode.js",
2726
"ui/dialog.js"
2827
]

tests/unit/dialog/dialog_options.js

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -283,15 +283,6 @@ test("height", function() {
283283
element.remove();
284284
});
285285

286-
asyncTest( "hide, #5860 - don't leave effects wrapper behind", function() {
287-
expect( 1 );
288-
$( "#dialog1" ).dialog({ hide: "clip" }).dialog( "close" ).dialog( "destroy" );
289-
setTimeout(function() {
290-
equal( $( ".ui-effects-wrapper" ).length, 0 );
291-
start();
292-
}, 500);
293-
});
294-
295286
test("maxHeight", function() {
296287
expect(3);
297288

ui/dialog.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,7 @@ return $.widget( "ui.dialog", {
168168
// Without detaching first, the following becomes really slow
169169
.detach();
170170

171-
this.uiDialog.stop( true, true ).remove();
171+
this.uiDialog.remove();
172172

173173
if ( this.originalTitle ) {
174174
this.element.attr( "title", this.originalTitle );

0 commit comments

Comments
 (0)