Dialog tests in IE8 with jQuery 1.7 #1481
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Effects wrappers are no longer used, so the workaround and test are no longer necessary. This fixes tests in IE8 with jQuery 1.7. Effectively a complete revert of 13505e5
| testFn(); | ||
| element.remove(); | ||
| setTimeout( next ); | ||
| testFn(function done() { |
There was a problem hiding this comment.
Just wondering: Is the done function name necessary? Or just a help for debugging?
There was a problem hiding this comment.
Just for debugging.
|
👍 |
scottgonzalez
added a commit
that referenced
this pull request
Mar 11, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets us to green for dialog in IE8 with jQuery 1.7.