Skip to content

Commit 796a8b3

Browse files
committed
Spinner: Don't change value when changing min/max options
Fixes #9703 Closes gh-1252
1 parent 9a93a06 commit 796a8b3

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

tests/unit/spinner/spinner_events.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ test( "stop", function() {
122122
});
123123

124124
asyncTest( "change", function() {
125-
expect( 14 );
125+
expect( 12 );
126126
var element = $( "#spin" ).spinner();
127127

128128
function shouldChange( expectation, msg ) {
@@ -239,13 +239,13 @@ asyncTest( "change", function() {
239239
shouldChange( false, "value, same value" );
240240
element.spinner( "value", 999 );
241241

242-
shouldChange( true, "max, value changed" );
242+
shouldChange( false, "max, value not changed" );
243243
element.spinner( "option", "max", 900 );
244244

245245
shouldChange( false, "max, value not changed" );
246246
element.spinner( "option", "max", 1000 );
247247

248-
shouldChange( true, "min, value changed" );
248+
shouldChange( false, "min, value not changed" );
249249
element.spinner( "option", "min", 950 );
250250

251251
shouldChange( false, "min, value not changed" );

ui/spinner.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -403,7 +403,6 @@ return $.widget( "ui.spinner", {
403403

404404
_setOptions: spinner_modifier(function( options ) {
405405
this._super( options );
406-
this._value( this.element.val() );
407406
}),
408407

409408
_parse: function( val ) {

0 commit comments

Comments
 (0)