Spinner: don't change value when changing min/max options#1252
Closed
petersendidit wants to merge 1 commit into
Closed
Spinner: don't change value when changing min/max options#1252petersendidit wants to merge 1 commit into
petersendidit wants to merge 1 commit into
Conversation
Member
|
Looks good. We're still updating the input's value when the |
Member
|
When you land this, please update the first word in the commit message after the component to be capitalized. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9703
This change feels weird not setting/checking the value after any option changes but min/max seem to be the only options that use alter the value.