Skip to content

Commit 90c27b4

Browse files
committed
Sortable: Add classes option
Ref #7053 Ref gh-1411
1 parent 491bb9c commit 90c27b4

File tree

1 file changed

+19
-15
lines changed

1 file changed

+19
-15
lines changed

ui/sortable.js

Lines changed: 19 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ return $.widget("ui.sortable", $.ui.mouse, {
8484

8585
_create: function() {
8686
this.containerCache = {};
87-
this.element.addClass("ui-sortable");
87+
this._addClass( "ui-sortable" );
8888

8989
//Get the items
9090
this.refresh();
@@ -111,19 +111,19 @@ return $.widget("ui.sortable", $.ui.mouse, {
111111
},
112112

113113
_setHandleClassName: function() {
114-
this.element.find( ".ui-sortable-handle" ).removeClass( "ui-sortable-handle" );
114+
var that = this;
115+
this._removeClass( this.element.find( ".ui-sortable-handle" ), "ui-sortable-handle" );
115116
$.each( this.items, function() {
116-
( this.instance.options.handle ?
117-
this.item.find( this.instance.options.handle ) : this.item )
118-
.addClass( "ui-sortable-handle" );
117+
that._addClass(
118+
this.instance.options.handle ?
119+
this.item.find( this.instance.options.handle ) :
120+
this.item,
121+
"ui-sortable-handle"
122+
);
119123
});
120124
},
121125

122126
_destroy: function() {
123-
this.element
124-
.removeClass( "ui-sortable ui-sortable-disabled" )
125-
.find( ".ui-sortable-handle" )
126-
.removeClass( "ui-sortable-handle" );
127127
this._mouseDestroy();
128128

129129
for ( var i = this.items.length - 1; i >= 0; i-- ) {
@@ -308,7 +308,7 @@ return $.widget("ui.sortable", $.ui.mouse, {
308308

309309
this.dragging = true;
310310

311-
this.helper.addClass("ui-sortable-helper");
311+
this._addClass( this.helper, "ui-sortable-helper" );
312312
this._mouseDrag(event); //Execute the drag once - this causes the helper not to be visible before getting its correct position
313313
return true;
314314

@@ -477,7 +477,8 @@ return $.widget("ui.sortable", $.ui.mouse, {
477477
this._mouseUp({ target: null });
478478

479479
if(this.options.helper === "original") {
480-
this.currentItem.css(this._storedCSS).removeClass("ui-sortable-helper");
480+
this.currentItem.css( this._storedCSS );
481+
this._removeClass( this.currentItem, "ui-sortable-helper" );
481482
} else {
482483
this.currentItem.show();
483484
}
@@ -790,9 +791,11 @@ return $.widget("ui.sortable", $.ui.mouse, {
790791
element: function() {
791792

792793
var nodeName = that.currentItem[0].nodeName.toLowerCase(),
793-
element = $( "<" + nodeName + ">", that.document[0] )
794-
.addClass(className || that.currentItem[0].className+" ui-sortable-placeholder")
795-
.removeClass("ui-sortable-helper");
794+
element = $( "<" + nodeName + ">", that.document[0] );
795+
796+
that._addClass( element, "ui-sortable-placeholder",
797+
className || that.currentItem[ 0 ].className )
798+
._removeClass( element, "ui-sortable-helper" );
796799

797800
if ( nodeName === "tbody" ) {
798801
that._createTrPlaceholder(
@@ -1218,7 +1221,8 @@ return $.widget("ui.sortable", $.ui.mouse, {
12181221
this._storedCSS[i] = "";
12191222
}
12201223
}
1221-
this.currentItem.css(this._storedCSS).removeClass("ui-sortable-helper");
1224+
this.currentItem.css( this._storedCSS );
1225+
this._removeClass( this.currentItem, "ui-sortable-helper" );
12221226
} else {
12231227
this.currentItem.show();
12241228
}

0 commit comments

Comments
 (0)