Classes

[arschmitz]

This addes a new built in option to the widget factory classes which maps structural classes to theme classes. To make this possible it introduces three new documented widget methods _addClass, _removeClass, and _toggleClass.

• Droppable - switch activeClass and hoverClass to use classes instead
• Resizable - Switch ghost option to use classes instead
• Should resizable have an icon option? NO (IRC Log) arschmitz@f0d8601#commitcomment-9961378

[jzaefferer]

jQuery's add method order elements by DOM position, even when detached. I don't know the exact complexity of that method, but its very slow for more than a handful of elements. Is there a way to avoid using add completely?

If not, what are the odds for current containing more than 1, 10 and 100 elements?

[scottgonzalez]

Whenever .not() is used, a new jQuery instance is needed with no stack to avoid memory leaks. See _off() for an example.

[scottgonzalez]

We can avoid the ordering slowness with (untested):

current = $( $.unique( current.get().concat( element.get() ) ) );

This would have decent parity with the required .not() handling too :-P

[jzaefferer]

Since the empty default classes are gone, can you start a list somewhere that list all the properties for each classes option for each widget? We can then use that for the API docs.

[scottgonzalez]

Is this trying to clone a jQuery instance?

[scottgonzalez]

Extraneous space after =.

[jzaefferer]

Existing issue, should probably address it here anyway: This call duplicates parts of refresh(), which is called later in this method. Maybe there is a reason for the duplication, but I guess that its just an oversight. If so, this line should be dropped.