Skip to content

Commit a856dd9

Browse files
committed
Slider: Convert tests to new infrastructure
Ref #10119 Ref gh-1528
1 parent 3522fd9 commit a856dd9

File tree

6 files changed

+34
-41
lines changed

6 files changed

+34
-41
lines changed

tests/unit/slider/slider.html

+2-25
Original file line numberDiff line numberDiff line change
@@ -4,31 +4,8 @@
44
<meta charset="utf-8">
55
<title>jQuery UI Slider Test Suite</title>
66

7-
<script src="../../jquery.js"></script>
8-
<link rel="stylesheet" href="../../../external/qunit/qunit.css">
9-
<script src="../../../external/qunit/qunit.js"></script>
10-
<script src="../../../external/jquery-simulate/jquery.simulate.js"></script>
11-
<script src="../testsuite.js"></script>
12-
<script src="../../../external/qunit-assert-classes/qunit-assert-classes.js"></script>
13-
<script>
14-
TestHelpers.loadResources({
15-
css: [ "core", "slider" ],
16-
js: [
17-
"ui/core.js",
18-
"ui/widget.js",
19-
"ui/mouse.js",
20-
"ui/slider.js"
21-
]
22-
});
23-
</script>
24-
25-
<script src="slider_common.js"></script>
26-
<script src="slider_core.js"></script>
27-
<script src="slider_events.js"></script>
28-
<script src="slider_methods.js"></script>
29-
<script src="slider_options.js"></script>
30-
31-
<script src="../swarminject.js"></script>
7+
<script src="../../lib/css.js" data-modules="core slider"></script>
8+
<script src="../../lib/bootstrap.js" data-widget="slider"></script>
329
</head>
3310
<body>
3411

tests/unit/slider/slider_common.js

+8-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,9 @@
1-
TestHelpers.commonWidgetTests( "slider", {
1+
define( [
2+
"lib/common",
3+
"ui/slider"
4+
], function( common ) {
5+
6+
common.testWidget( "slider", {
27
defaults: {
38
animate: false,
49
cancel: "input, textarea, button, select, option",
@@ -26,3 +31,5 @@ TestHelpers.commonWidgetTests( "slider", {
2631
stop: null
2732
}
2833
});
34+
35+
} );

tests/unit/slider/slider_core.js

+5-5
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1-
(function( $ ) {
2-
//
3-
// Slider Test Helper Functions
4-
//
1+
define( [
2+
"jquery",
3+
"ui/slider"
4+
], function( $ ) {
55

66
var element, options;
77

@@ -306,4 +306,4 @@ test( "keydown LEFT on handle decreases value by step, not less than min", funct
306306
element.slider( "destroy" );
307307
});
308308

309-
})( jQuery );
309+
} );

tests/unit/slider/slider_events.js

+5-2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,7 @@
1-
(function( $ ) {
1+
define( [
2+
"jquery",
3+
"ui/slider"
4+
], function( $ ) {
25

36
module( "slider: events" );
47

@@ -202,4 +205,4 @@ test( "event data", function() {
202205
handles.eq( slideHandleIndex ).simulate( "drag", { dx: 10 } );
203206
});
204207

205-
})( jQuery );
208+
} );

tests/unit/slider/slider_methods.js

+7-4
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,7 @@
1-
(function( $ ) {
1+
define( [
2+
"jquery",
3+
"ui/slider"
4+
], function( $ ) {
25

36
module( "slider: methods" );
47

@@ -23,9 +26,9 @@ test( "init", function() {
2326
ok( true, "arbitrary option setter after init" );
2427
});
2528

26-
test( "destroy", function() {
29+
test( "destroy", function( assert ) {
2730
expect( 1 );
28-
domEqual( "#slider1", function() {
31+
assert.domEqual( "#slider1", function() {
2932
$( "#slider1" ).slider().slider( "destroy" );
3033
});
3134
});
@@ -110,4 +113,4 @@ test( "value", function() {
110113
// ok(false, "missing test - untested code is broken code." );
111114
//});
112115

113-
})( jQuery );
116+
} );

tests/unit/slider/slider_options.js

+7-4
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,7 @@
1-
(function( $ ) {
1+
define( [
2+
"jquery",
3+
"ui/slider"
4+
], function( $ ) {
25

36
var element, options;
47

@@ -54,7 +57,7 @@ test( "max", function() {
5457
element.slider( options );
5558
ok( element.slider( "option", "value" ) === options.value, "value option is not contained by max" );
5659
ok( element.slider( "value" ) === options.max, "value method is contained by max" );
57-
60+
5861
options = {
5962
max: 9,
6063
min: 1,
@@ -65,7 +68,7 @@ test( "max", function() {
6568

6669
element.slider( options );
6770
ok( element.slider( "value" ) === 7, "value method is within max, edge Case" );
68-
71+
6972
options.step = 2;
7073

7174
element.slider( options );
@@ -343,4 +346,4 @@ test( "range", function( assert ) {
343346
element.slider( "destroy" );
344347
});
345348

346-
})( jQuery );
349+
} );

0 commit comments

Comments
 (0)