Skip to content

Commit e39ee9d

Browse files
committed
Accordion: Convert tests to new infrastructure
Ref #10119 Ref gh-1528
1 parent 2e1c72f commit e39ee9d

7 files changed

+54
-49
lines changed

tests/unit/accordion/accordion.html

+2-25
Original file line numberDiff line numberDiff line change
@@ -4,31 +4,8 @@
44
<meta charset="utf-8">
55
<title>jQuery UI Accordion Test Suite</title>
66

7-
<script src="../../jquery.js"></script>
8-
<link rel="stylesheet" href="../../../external/qunit/qunit.css">
9-
<script src="../../../external/qunit/qunit.js"></script>
10-
<script src="../../../external/jquery-simulate/jquery.simulate.js"></script>
11-
<script src="../testsuite.js"></script>
12-
<script src="../../../external/qunit-assert-classes/qunit-assert-classes.js"></script>
13-
<script>
14-
TestHelpers.loadResources({
15-
css: [ "core", "accordion" ],
16-
js: [
17-
"ui/core.js",
18-
"ui/widget.js",
19-
"ui/accordion.js"
20-
]
21-
});
22-
</script>
23-
24-
<script src="accordion_test_helpers.js"></script>
25-
<script src="accordion_common.js"></script>
26-
<script src="accordion_core.js"></script>
27-
<script src="accordion_events.js"></script>
28-
<script src="accordion_methods.js"></script>
29-
<script src="accordion_options.js"></script>
30-
31-
<script src="../swarminject.js"></script>
7+
<script src="../../lib/css.js" data-modules="core accordion"></script>
8+
<script src="../../lib/bootstrap.js" data-widget="accordion"></script>
329
<style>
3310
#list, #list1 *, #navigation, #navigation * {
3411
margin: 0;

tests/unit/accordion/accordion_common.js

+8-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,9 @@
1-
TestHelpers.commonWidgetTests( "accordion", {
1+
define( [
2+
"lib/common",
3+
"ui/accordion"
4+
], function( common ) {
5+
6+
common.testWidget( "accordion", {
27
defaults: {
38
active: 0,
49
animate: {},
@@ -23,3 +28,5 @@ TestHelpers.commonWidgetTests( "accordion", {
2328
create: null
2429
}
2530
});
31+
32+
} );

tests/unit/accordion/accordion_core.js

+8-4
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,11 @@
1-
(function( $ ) {
1+
define( [
2+
"jquery",
3+
"./accordion_test_helpers",
4+
"ui/accordion"
5+
], function( $, accordionTestHelper ) {
26

3-
var setupTeardown = TestHelpers.accordion.setupTeardown,
4-
state = TestHelpers.accordion.state;
7+
var setupTeardown = accordionTestHelper.setupTeardown,
8+
state = accordionTestHelper.state;
59

610
module( "accordion: core", setupTeardown() );
711

@@ -200,4 +204,4 @@ asyncTest( "keyboard support", function( assert ) {
200204
}
201205
});
202206

203-
}( jQuery ) );
207+
} );

tests/unit/accordion/accordion_events.js

+8-4
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,11 @@
1-
(function( $ ) {
1+
define( [
2+
"jquery",
3+
"./accordion_test_helpers",
4+
"ui/accordion"
5+
], function( $, accordionTestHelper ) {
26

3-
var setupTeardown = TestHelpers.accordion.setupTeardown,
4-
state = TestHelpers.accordion.state;
7+
var setupTeardown = accordionTestHelper.setupTeardown,
8+
state = accordionTestHelper.state;
59

610
module( "accordion: events", setupTeardown() );
711

@@ -161,4 +165,4 @@ test( "activate", function() {
161165
element.accordion( "option", "active", 1 );
162166
});
163167

164-
}( jQuery ) );
168+
} );

tests/unit/accordion/accordion_methods.js

+11-7
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,18 @@
1-
(function( $ ) {
1+
define( [
2+
"jquery",
3+
"./accordion_test_helpers",
4+
"ui/accordion"
5+
], function( $, accordionTestHelper ) {
26

3-
var equalHeight = TestHelpers.accordion.equalHeight,
4-
setupTeardown = TestHelpers.accordion.setupTeardown,
5-
state = TestHelpers.accordion.state;
7+
var equalHeight = accordionTestHelper.equalHeight,
8+
setupTeardown = accordionTestHelper.setupTeardown,
9+
state = accordionTestHelper.state;
610

711
module( "accordion: methods", setupTeardown() );
812

9-
test( "destroy", function() {
13+
test( "destroy", function( assert ) {
1014
expect( 1 );
11-
domEqual( "#list1", function() {
15+
assert.domEqual( "#list1", function() {
1216
$( "#list1" ).accordion().accordion( "destroy" );
1317
});
1418
});
@@ -129,4 +133,4 @@ test( "widget", function() {
129133
strictEqual( widgetElement[ 0 ], element[ 0 ], "same element" );
130134
});
131135

132-
}( jQuery ) );
136+
} );

tests/unit/accordion/accordion_options.js

+9-5
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,12 @@
1-
(function( $ ) {
1+
define( [
2+
"jquery",
3+
"./accordion_test_helpers",
4+
"ui/accordion"
5+
], function( $, accordionTestHelper ) {
26

3-
var equalHeight = TestHelpers.accordion.equalHeight,
4-
setupTeardown = TestHelpers.accordion.setupTeardown,
5-
state = TestHelpers.accordion.state;
7+
var equalHeight = accordionTestHelper.equalHeight,
8+
setupTeardown = accordionTestHelper.setupTeardown,
9+
state = accordionTestHelper.state;
610

711
module( "accordion: options", setupTeardown() );
812

@@ -460,4 +464,4 @@ test( "{ icons: hash }", function( assert ) {
460464
assert.hasClasses( element.find( ".ui-accordion-header.ui-state-active span.ui-icon" ), "a2" );
461465
});
462466

463-
}( jQuery ) );
467+
} );

tests/unit/accordion/accordion_test_helpers.js

+8-3
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
1-
TestHelpers.accordion = {
1+
define( function() {
2+
3+
return {
24
equalHeight: function( accordion, height ) {
35
accordion.find( ".ui-accordion-content" ).each(function() {
46
equal( $( this ).outerHeight(), height );
@@ -20,8 +22,11 @@ TestHelpers.accordion = {
2022
state: function( accordion ) {
2123
var expected = $.makeArray( arguments ).slice( 1 ),
2224
actual = accordion.find( ".ui-accordion-content" ).map(function() {
23-
return $( this ).css( "display" ) === "none" ? 0 : 1;
24-
}).get();
25+
return $( this ).css( "display" ) === "none" ? 0 : 1;
26+
}).get();
2527
QUnit.push( QUnit.equiv(actual, expected), actual, expected );
2628
}
29+
2730
};
31+
32+
} );

0 commit comments

Comments
 (0)