Skip to content

Demos: Autocomplete as a combobox does no more show the dropdown button #2295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
fredericDelaporte opened this issue Sep 26, 2024 · 5 comments · Fixed by #2296
Closed

Demos: Autocomplete as a combobox does no more show the dropdown button #2295

fredericDelaporte opened this issue Sep 26, 2024 · 5 comments · Fixed by #2296
Labels
Behavior different from 1.12 Comp: Demos
Milestone
1.14.1

Comments

@fredericDelaporte
Copy link

The autocomplete widget as a combobox does no more show its dropdown button.

That is visible in the documentation examples, here.
@mgol
Copy link
Member

mgol commented Sep 27, 2024

Thanks for the report. Does the issue you describe exist when jQuery UI 1.12.1 is used or only with jQuery UI 1.13.0 or newer?

@fredericDelaporte
Copy link
Author

fredericDelaporte commented Sep 27, 2024 •
edited
Loading

No idea about when this trouble has appeared on the jQuery UI documentation site.

On a private application I am working on, the trouble is not there on the commit preceding an upgrade from jQuery UI v1.13.3 to v1.14.0, and is there on the commit doing that upgrade.

@mgol
Copy link
Member

mgol commented Sep 27, 2024

Thanks for the info! I narrowed it down to be caused by disabling back compat (i.e. setting $.uiBackCompat to false in jQuery UI 1.13 or older or by NOT setting it to true in jQuery UI 1.14). What's left is to understand why this flag matters here and if there's some logic we should move to not be dependent on this flag.

@mgol mgol added this to the 1.14.1 milestone Sep 27, 2024
@mgol mgol mentioned this issue Sep 27, 2024
Merged
@mgol
Copy link
Member

mgol commented Sep 27, 2024

Fortunately, this was just an issue with the demo which used deprecated button options: icons and text.

I fixed the demos in PR #2296.

mgol added a commit to mgol/jquery-ui that referenced this issue Sep 27, 2024
@mgol
Demos: Remove deprecated button APIs
821d076 
Remove usage of deprecated button options:
* `icons`: https://jqueryui.com/upgrade-guide/1.12/#deprecated-icons-options-in-favor-of-icon-and-iconposition
* `text`: https://jqueryui.com/upgrade-guide/1.12/#deprecated-text-option-in-favor-of-showlabel

Fixes jquerygh-2295
@mgol mgol closed this as completed in b8fff16 Sep 30, 2024
@mgol mgol changed the title Autocomplete as a combobox does no more show the dropdown button Demos: Autocomplete as a combobox does no more show the dropdown button Oct 6, 2024
@mgol
Copy link
Member

mgol commented Oct 30, 2024

The demo works correctly now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Behavior different from 1.12 Comp: Demos
Milestone
1.14.1
Development

Successfully merging a pull request may close this issue.

Demos: Remove deprecated button APIs mgol/jquery-ui
2 participants
@mgol @fredericDelaporte