-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Export manifest logic #1015
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export manifest logic #1015
Conversation
This work is in progress. It's pulled now, so we can discuss some things, see below. |
@@ -0,0 +1,86 @@ | |||
var categories, flatten, manifest, pkg, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I placed the manifest code in build/manifest.js
. Any other better place?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's fine.
@scottgonzalez @jzaefferer thoughts? ^ |
"http://api.jqueryui.com/category/scrollParent/", | ||
"http://api.jqueryui.com/category/tabbable-selector/", | ||
"http://api.jqueryui.com/category/uniqueId/", | ||
"http://api.jqueryui.com/category/zIndex/" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are all wrong. None of these pages are categories.
If we accept the proposal below, we don't need this PR anymore. |
@scottgonzalez, @jzaefferer we've talked in Portland about adding extra data in UI manifests via the Right now, we're adding extra data into the manifests to address one issue: let DownloadBuilder know how to expand a documentation category into its corresponding pages and posts. Documentation is the scope of api.jqueryui.com. So, instead of augmenting the manifests here, we could delegate that "responsibility" to api.jqueryui.com. This new proposal workflow works the following way:
|
I like the api.jqueryui.com approach. |
Manifest files are currently created by running
grunt manifest
task.In order to give 3rd party applications (eg. download builder) custom control over manifests, eg. ability to merge special
_
field (we need a name for this special feature), this PR exports manifest API.