Sortable: added checks for the helper touching the edge of the containme...

[m-orchard]

...nt while dragging. Fixed #5772 - Sortable: containment parent restricting replacement of first and last elements

This issue can be reproduced based on where the mouse is positioned when sorting - in the patched versions you can drag from anywhere in the item to trigger a rearrangement, where as in the unpatched versions you must drag such that the initial mouse down position inside the item will overlap with the target item.

Example fiddles:
Horizontal
Horizontal Patched
Vertical
Vertical Patched
2D
2D Patched

There is also an existing issue where the vertical container will be pushed down when sorting into the last index, which is not fixed in this pull request.

[mikesherov]

Thanks for contributing! In order for us to review this patch, we'll need just a few more things:

1. Please turn those fantastic jsfiddles into actual unit tests (and verify they're working).
2. Sign our CLA: http://contribute.jquery.org/CLA/
3. Even though surrounding code doesn't necessarily conform to it, please format your new code to our style format: http://contribute.jquery.org/style-guide/js/

Thanks again for contributing and let me know if you have any questions!

[m-orchard]

Sorry for the very, very slow response to this! I've updated my pull request with better formatting, added some tests, and signed the CLA. Please let me know if there's anything else that should be fixed. :)

[atul516]

Hi,
Can we expect this fix to be in a release? I suppose it fixes http://bugs.jqueryui.com/ticket/5772

[lukeapage]

@scottgonzalez do you know why this PR stalled? It was made by a colleague of mine. Is it worth me bringing it up to date with master?
There also seem quite a few other stalled PR's - I well understand some PR's are controversial but it would be good to know the status or what something is waiting on - or if the core team thinks it is not right to be merged then to close the PR with an explanation.

[mikesherov]

Yes, this is worth bringing up to date with master. Thanks again!

Typically, a PR is stalled because it's made against a widget that is currently undergoing a rewrite or expected to be rewritten soon, or we respond and it takes a while for the patch author to respond to our comments. Some things just get lost in the shuffle.

Please update this and then ping me and I'll look into getting it merged!

Thanks again

[lukeapage]

moved to #1424
@mickylad can you close this?