Skip to content

Fixed #9533 - Position: positioning within document raises error #1072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
meyertee wants to merge 2 commits into from
Closed

Fixed #9533 - Position: positioning within document raises error #1072

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4707e12
avoid reading overflow css on document
meyertee Sep 4, 2013
9564b4c
added unit test to check for error when positioning within document
meyertee Sep 4, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
added unit test to check for error when positioning within document
  • Loading branch information
@meyertee
meyertee committed Sep 4, 2013
commit 9564b4c88521fa451e149e173457a65baacfc87c
9 changes: 8 additions & 1 deletion tests/unit/position/position_core.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -575,7 +575,14 @@ test( "collision: flip, with margin", function() {
});

test( "within", function() {
expect( 6 );
expect( 7 );

collisionTest({
within : document
Copy link
Member

@jzaefferer jzaefferer Dec 3, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No space before the colon, same thing for the next two.

}, {
top : 10,
left : 10
}, "within document (bug #9533)");
Copy link
Member

@jzaefferer jzaefferer Dec 3, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we have a few ticket references here and there, we should avoid them. The test speaks for itself. Can you remove the reference?


collisionTest({
within: "#within",
Expand Down