Fixed #9534 - Position: positioning against an iframe's contentWindow calculates wrong positions#1073
Closed
meyertee wants to merge 2 commits intojquery:masterfrom
Closed
Fixed #9534 - Position: positioning against an iframe's contentWindow calculates wrong positions#1073meyertee wants to merge 2 commits intojquery:masterfrom
meyertee wants to merge 2 commits intojquery:masterfrom
Conversation
… Fixed #9534 - positioning against an iframe's contentWindow calculates wrong positions
Member
|
The underlying ticket is still in status "new", waiting for an update on a jQuery Core ticket. Until we've got a response there, this PR will probably have to linger a little longer. Otherwise it looks good (CLA signed, unit test in place). There's some missing whitespace, I'll comment inline, but we can also fix that later, once we accept the ticket as valid. |
Contributor
Author
|
Thanks for looking into it, I'll fix the whitespace in the next few days. |
Member
|
Following up on the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug #9534
Using innerWidth/innerHeight properties to get window size rather than width()/height().
Added unit test for this case.
http://bugs.jqueryui.com/ticket/9534
http://jsfiddle.net/meyertee/mzPvj/