Skip to content

Tabs: Make tabs('url') work as a getter #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

pmcelhaney
Copy link

I was disappointed to find there's no way to get the URL of the currently selected tab, so I modified the url() function to work as an accessor as well as a mutator. Also added unit tests.

// Existing signature: set a URL
el.tabs('url', 1, '#newurl');

// New signature: get the URL of tab 1
url = el.tabs('url', 1);

// New signature: get the selected tab's URL
url = el.tabs('url');

This is my first attempt at contributing to jQuery UI. Please let me know if I should do anything differently.

@scottgonzalez
Copy link
Member

Thanks for the patch, but we're removing the url method. See forum.jquery.com/topic/tabs-api-redesign for more details.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants