Tabs: Make tabs('url') work as a getter #109
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was disappointed to find there's no way to get the URL of the currently selected tab, so I modified the url() function to work as an accessor as well as a mutator. Also added unit tests.
// Existing signature: set a URL
el.tabs('url', 1, '#newurl');
// New signature: get the URL of tab 1
url = el.tabs('url', 1);
// New signature: get the selected tab's URL
url = el.tabs('url');
This is my first attempt at contributing to jQuery UI. Please let me know if I should do anything differently.