Dialog: Safe activeElement access.#1096
Closed
tjvantoll wants to merge 2 commits intojquery:masterfrom
Closed
Conversation
Fixed #9420 - Dialog: Close causes blur of window in IE9 Fixed #8443 - Dialog: "unspecified error" when using ie9 and iframe
Member
Author
|
I hate the idea of putting more things in core but this is painful and this isn't the last time we're going to run into this. |
ui/jquery.ui.dialog.js
Outdated
Member
There was a problem hiding this comment.
You reference document.activeElement three times, so might as well assign that here as activeElement and use that.
Member
There was a problem hiding this comment.
Yeah, let's just create activeElement and not document.
Member
|
Other than @jzaefferer's comment, there should be a blank line above each comment. Looks good otherwise. |
Member
Author
|
Landed in 2dfe85d. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed #9420 - Dialog: Close causes blur of window in IE9
Fixed #8443 - Dialog: "unspecified error" when using ie9 and iframe
Man does this feel dirty.