Menu style, experimental #1128
Merged
Menu style, experimental #1128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I personally don't care whether or not we have borders on the items. We might want to switch from |
…moval of anchors, which caused a text cursor to appear on non-disabled items.
|
@jzaefferer exactly this runs fine in my machine but travis build failed - when i rebased and pushed. #1092 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've updated the branch that @scottgonzalez started. I didn't change much, mostly adding two multi-line items to be able to visually compare single and multi line items.
I also noticed that menu-items ended up with a text-cursor, caused by the removal of anchors. I've fixed that by explicitly setting cursor:pointer. If we end up not using this branch, I can cherry-pick that commit to master.
Mostly looking for someone to verify that this new style is actually better then the old one. This is now much more similar to the menubar menus in OSX, which we used a lot as a reference for menu. Though maybe we also need to get of the borders, along with the margin: -1px 'hack' that we currently have.