Closed
Conversation
Member
|
Hi @brunobg, Thanks for taking the time to contribute to jQuery UI. We have the following requirements of pull requests before we can review them.
You'll also want to avoid sending a pull request from your master branch. See http://contribute.jquery.org/commits-and-pull-requests/. I'm going to close this for now. If you are interested in pursuing this please open a new PR that addresses these items. Thanks. |
Author
|
Hi tjvantoli. I understand your guidelines. I signed the CLA and it is a minor patch that fixes a well known bug open for 3 years (http://bugs.jqueryui.com/ticket/7098). The code follows your style guide, but I do not have time to become a full developer. I hope someone can deal with it properly instead of throwing the patch away. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Datepicker: fixed problem with years between 1 and 99 (but broke two tests and I cannot figure why, see below). Fixed #7098 - Datepicker: Broken handling of four digit years before year 100
Broke test 21:18
Broke test 24:15