Skip to content

Fixes for 2 digit years#1142

Closed
brunobg wants to merge 1 commit intojquery:masterfrom
Corollarium:master
Closed

Fixes for 2 digit years#1142
brunobg wants to merge 1 commit intojquery:masterfrom
Corollarium:master

Conversation

@brunobg
Copy link

@brunobg brunobg commented Nov 26, 2013

Datepicker: fixed problem with years between 1 and 99 (but broke two tests and I cannot figure why, see below). Fixed #7098 - Datepicker: Broken handling of four digit years before year 100

Broke test 21:18

Year Range Test - previous button disabled at 1/1/minYear
Source:     
@file:///git/jquery-ui/tests/unit/datepicker/datepicker_options.js:493

Broke test 24:15

Auto size - he - DD, MM dd, yy
Expected:   

23

Result:     

21

Diff:   

23 21 

Source:     

@file:///git/jquery-ui/tests/unit/datepicker/datepicker_options.js:668

@tjvantoll
Copy link
Member

Hi @brunobg,

Thanks for taking the time to contribute to jQuery UI. We have the following requirements of pull requests before we can review them.

  • Sign our CLA.
  • Include a unit test to ensure the fix works and prevent against regressions.
  • Ensure code adheres to our style guide.
  • Ensure commit messages adhere to our commit message style guide.
  • Change your git config to use your real name.

You'll also want to avoid sending a pull request from your master branch. See http://contribute.jquery.org/commits-and-pull-requests/.

I'm going to close this for now. If you are interested in pursuing this please open a new PR that addresses these items. Thanks.

@tjvantoll tjvantoll closed this Nov 26, 2013
@brunobg
Copy link
Author

brunobg commented Nov 26, 2013

Hi tjvantoli. I understand your guidelines. I signed the CLA and it is a minor patch that fixes a well known bug open for 3 years (http://bugs.jqueryui.com/ticket/7098). The code follows your style guide, but I do not have time to become a full developer. I hope someone can deal with it properly instead of throwing the patch away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants