Tooltip: on close and destroy only set title if empty or undefined. Fixed #8925 - Changes to title attribute are reverted on close#1143
Closed
robotdan wants to merge 2 commits into
Closed
Tooltip: on close and destroy only set title if empty or undefined. Fixed #8925 - Changes to title attribute are reverted on close#1143robotdan wants to merge 2 commits into
robotdan wants to merge 2 commits into
Conversation
…ed #8925 - Changes to title attribute are reverted on close Ticket #8925 states that changes to the title attribute while the tooltip is open are lost on tooltip close. In the close and destroy functions, the title attribute is always written if a value was stored in the element on open. It is possible the attribute has changed and restoring the initial value may overwrite the current value. If the value is empty or undefined as set in open, do not set the title attribute. This fix has the limitation that if the user removed the title attribute or set the value to an empty string the original title value would be restored on close and destroy. Test cases 3 and 4 demonstrate this limitation.
Member
|
Your git config still has incorrect information in it. The email address doesn't match the one you used to sign the CLA and your name isn't set properly. This needs to be fixed before we can review the change. Let us know if you need help getting that fixed. |
…ine. Fixed #8925 - Changes to title attribute are reverted on close" This reverts commit 951d1fc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket #8925 states that changes to the title attribute while the tooltip is open are lost on tooltip close.
In the close and destroy functions, the title attribute is always written if a value was stored in the element on open. It is possible the attribute has changed and restoring the initial value may overwrite the current value.
If the value is empty or undefined as set in open, do not set the title attribute.
This fix has the limitation that if the user removed the title attribute or set the value to an empty string the original title value would be restored on close and destroy. Test cases 3 and 4 demonstrate this limitation.