Draggable: Test fix regarding static scrolling #1145
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No longer checking scroll positions of static scrolls since the fixture is in an absolute container.
|
Hi @DaveStein , Thanks for taking the time to contribute to jQuery UI. We have the following requirements of pull requests before we can review them.
Deal? |
|
@jzaefferer Hey, this is Dave from the jquery-meeting room who works with @mikesherov. The test itself was bad and does not require any other tickets or unit tests. You can confirm with Mike. |
|
@DaveStein sorry for the bad bureaucracy joke. The "Deal?" was supposed to give it away... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No longer checking scroll positions of static scrolls since the fixture is
in an absolute container.
This one's for you @mikesherov