Skip to content

Conversation

@mwiencek
Copy link
Contributor

Fixes #9719

@mwiencek
Copy link
Contributor Author

The condition that decides whether to move the title attribute to ui-tooltip-title is line 129 - it simply checks whether a title attribute exists. Changing the title to an empty string does not remove the attribute, so calling disable twice will save the empty string to ui-tooltip-title on the second call.

Added a test which demonstrates the problem, and fails without the patch applied.

Link to ticket: http://bugs.jqueryui.com/ticket/9719
Link to jsFiddle: http://jsfiddle.net/Trx2e/1/

@tjvantoll
Copy link
Member

Hi @mwiencek,

Thanks for taking the time to contribute to the jQuery UI project. Can you please sign our CLA so we can review this request?

@mwiencek
Copy link
Contributor Author

@tjvantoll sure, I've now signed and submitted the CLA.

@tjvantoll
Copy link
Member

Looks good to me. http://jsfiddle.net/tj_vantoll/3QqbA/ 👍

@jzaefferer jzaefferer closed this in 0dc84db Jan 9, 2014
@jzaefferer
Copy link
Member

Landed, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants