Skip to content

Resizable: whitespace fixed #1162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Resizable: whitespace fixed #1162

wants to merge 1 commit into from

Conversation

dekajp
Copy link
Contributor

@dekajp dekajp commented Jan 7, 2014

commit bae1a25 was causing dialog to fail and giving JS errors in console

with this commit . this problem is fixed.

More details is on this comment thread
20f0646#commitcomment-4997995

@mikesherov
Copy link
Member

/cc @jzaefferer

dekajp referenced this pull request Jan 7, 2014
@dekajp @mikesherov
Resizable: containment plugin restricts resizing within container
20f0646 
Fixes #7018
Fixes #9107
Closes gh-1122
@jzaefferer
Copy link
Member

I'm concerned that this didn't cause any failures in the resizable testsuite. Can you look into adding a test for this? If this wasn't caught, the test coverage for the containment plugin might be bad in general.

That said, I'm okay with landing this immediately and adding a test later...

@dekajp
Copy link
Contributor Author

dekajp commented Jan 7, 2014

valid concern . i wish i knew that i should run dialog unit test with resizable .

yes i would prefer to land this and i will add test later ..

@mikesherov
Copy link
Member

@jzaefferer all the interactions have pitiful coverage, except draggable now. With that said, @dekajp, would be great to add a test after this is merged.

On a side note, @dekajp, always run the whole suite before submitting PR's.

@dekajp
Copy link
Contributor Author

dekajp commented Jan 7, 2014

i always run grunt before push to avoid travis build failure i do not know where/how this got missed

@jzaefferer jzaefferer closed this in 9413043 Jan 9, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dekajp @mikesherov @jzaefferer