Sortable: Pass this to _uiHash() when firing 'remove' events. Fixes #9738: Remove event object doesn't contain sender when moving an item between connected sortables. #1171
Conversation
| ok( hash.position && ( "top" in hash.position && "left" in hash.position ), "UI hash includes: position" ); | ||
| ok( hash.offset && ( hash.offset.top && hash.offset.left ), "UI hash includes: offset" ); | ||
| ok( hash.item, "UI hash includes: item" ); | ||
| ok( hash.sender, "UI hash includes: sender" ); |
There was a problem hiding this comment.
Instead of just testing for existence, compare item and sender to the actual elements they should be set to.
|
I confirmed this works: http://jsfiddle.net/tj_vantoll/2snbn/. I will say that it's a little strange to need a fyi @NiGhTTraX our commit message guidelines have recently changed. You can either I have one minor comment otherwise this looks good to me. |
Fixes #9738: Remove event object doesn't contain sender when moving an item between connected sortables.
|
Updated and squashed. @tjvantoll I guess it's strange, but the documentation mentioned it. It would be more useful to have an attribute pointing to the list that received the element. |
|
Would it make more sense to just update the docs to reflect the current API? This seems more like a docs bug than an implementation bug. |
|
Essentially, I'm wondering if this consistency is providing actual benefit for some use cases. The ticket didn't provide a real use case, it just shows a bug based on the documentation (which in itself is a legitimate bug). Presumably this was never implemented and it's always been a documentation bug, but we've never received a ticket until now. |
|
I guess the best way would be to update the documentation. Should I create an issue at https://github.com/jquery/api.jqueryui.com ? |
|
That'd be great. Let me know if you plan to send a PR to fix the documentation as well. If not, I'll fix it after you file the issue. Thanks. |
|
Created issue jquery/api.jqueryui.com#188 and sent PR jquery/api.jqueryui.com#189 |
No description provided.