Ticket 6934 - Batch class changes#118
Closed
Adovenmuehle wants to merge 1 commit into
Closed
Conversation
…tton: Batch class changes to improve performance.
Member
|
Thanks, landed in 5b104db (removed the whitespace inside the if statements, but left the rest). |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tested using the visual/button/button_performance.html page in FF3.6.13, Chrome 9, and IE 8 and didn't see any significant difference in speeds between the old and new implementation.
I also looked in the rest of the code for button and didn't see any other areas that looked like they could easily use this optimization.