-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Bower Support #1189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bower Support #1189
Conversation
Fixes #9465
Per @scottgonzalez's suggestion I'm going to switch the manifest task to read the jQuery dependency from |
Well that was shockingly easy (0a6598e). |
The release script takes care of adding a version appropriately.
This looks good to me to land as is. That said, claiming the component should happen before the 1.11 release - and we still have to figure out how to deal with existing apps relying on older versions that we can't provide, since we already have existing tags that don't include the bower.json. |
Bower support will come with 1.11.0, whenever that lands, but datepicker will be odd. Please use IRC or the forums to continue discussions about use of Bower. |
Based on mailing list discussion, we shouldn't claim the existing component until we've talked to their maintainers, though if they're interested, we'd just keep them maintaing the package. We can and still should add a bower.json: To allow installs via |
@jzaefferer I agree. Given that is this good to merge? I'd prefer to handle |
Yeah, I think this is good to land. |
I'll bring this up at the team meeting tomorrow. Unless there are any objections I'll land this and close #9465. The original commit message still makes sense too I think. We are adding Bower support, we're just not claiming the official |
I figured I'd toss this out there so we have something to brainstorm about.
Here's what I see as the TODOs for external Bower support:
jquery-ui
component in Bower (Unregister package requests bower/bower#120).