fix 9790 - ESCAPE in autocomplete should not change multiline value. #1190
Conversation
| element.simulate( "keydown", { keyCode: $.ui.keyCode.ESCAPE } ); | ||
| equal( element.text(), customVal ); | ||
| start(); | ||
| }, 50 ); |
There was a problem hiding this comment.
Since the delay is set to 50 you should be able to drop this argument altogether.
There was a problem hiding this comment.
I copied, pasted and modified from the tests above.
|
Hi @Yermo, Thanks for this. For future reference we have guidelines about the format of commit messages. |
|
Oops. Sorry about that. I had seen those but forgot. Do you want me to make the edit you suggest above via another commit or will you do it? (Still relatively new to the github workflow so am stumbling around a bit.) |
|
If you're looking to learn it'd be great if you could make the change, add a new commit, squash the two commits into a single one that follows our commit message guidelines, and push the branch so the updates appear here. If you're not looking to learn we can take care of it. |
|
Always looking to learn. I'll take care of it (hopefully without too many mistakes. :) ) |
|
I had some trouble trying to push out the squashed commits and ended up doing a --force in order to move it out. Since I'm the only one pushing to this particular repository I'm assuming it's ok to do in this instance. (I understand that one would never do this to a public shared repository.) |
|
Yep this is fine. You can also drop "fix 9790" from the commit message, but we can clean that up. This looks good to me. |
|
What's the preferred way of changing a commit message? |
|
|
Fixed case where content of contenteditable or textarea was changed when ESCAPE pressed. Fixes: #9790
|
Done. Thanks for the hand holding. |
If ESCAPE is pressed with an opened menu on a contenteditable or textarea, do not change the value. This is similar to http://bugs.jqueryui.com/ticket/9771.