Draggable Tests: fix IE offset tests affected by focus issues.#1195
Merged
Conversation
Member
|
Shouldn't you enable JSCS on draggable if you've fixed the issues? |
Member
Author
|
Probably? |
Member
Author
|
Enabled JSCS on draggable. |
Member
Author
|
@scottgonzalez good to land? |
Member
|
Squash the JSCS related commits and land it. |
Calling element.focus() causes scroll in IE. In order to correctly test scroll behavior, we must rely on the actual calculated offset instead of the helper offset to ensure cross browser test consistency.
Calling element.focus() causes scroll in IE. In order to correctly test scroll behavior, we must calculate scrollTop on the drag event, before .focus is called.
Member
|
Looks good to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.