Replaced jquery.color with the new, modular jquery.colors.#12
Conversation
…rs. Fixed #4372 & #4635 (animate to transparent), #3806 (expose getRGB and getColor), #5215 (add support for rgba), #5393 (getColor reports inaccurate color for transparent elements in Webkit) as well as other enhancements (see pull request)
|
Thanks Enideo. Could you split this into several smaller commits so it's easier to review? Also, you might want to fork http://github.com/jquery/jquery-color and send pull requests there as that's the official home for this code, we just pull it into jQuery UI. |
|
Ok I'll try to break it down sometime but a little too busy at the moment. When I've time I'll try to go over the points for my jquery-ui changes |
|
I love this pull request and the associated independent jQuery extension. I needed it to fix jQuery's results when querying the DOM for a color. IE just returns it back exactly as typed in the stylesheet instead of some consistent color object/array. Scott, what would your recommendation be for this library? Even thought jQuery-color and jQueryUI have these services internally (unexposed), do you think it would be useful to have jQuery's css() function to leverage it for true color abstraction? Also, if in jQuery, the jQueryUI and color plugin could just use that directly. |
|
I'm not sure how .css() would be involved. What did you have in mind? |
Fixed the following bugs / requests:
However, the file size has doubled (extra 10kB when minified)!
Still, consider the following points:
PS new to github: first pull request for jquery ui!