Autocomplete: Search if the user retypes the same value #1238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. |
|
Cool. I'll give @scottgonzalez a chance to look this one over too. |
| event.metaKey || event.shiftKey; | ||
|
|
||
| if ( !equalValues || | ||
| ( equalValues && !menuVisible && !modifierKey ) ) { |
There was a problem hiding this comment.
It looks like this is short enough to fit on one line. If it's not, the second line needs an extra level of indentation to distinguish it from the body.
There was a problem hiding this comment.
It fits (under 100) and looks cleaner so I put it all on one line.
There was a problem hiding this comment.
The comment fits under 100 on the same line as well, so I think I'm going to make that one line too.
Fixes #7434 Closes jquerygh-1238
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7434