-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Datepicker: Fixed month names and firstDay value in Arabic locale #1246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @dralshehri, Can you please sign our CLA so we can review this? Thanks. |
I've just signed the CLA. |
Can you provide some insight into the changes for http://bugs.jqueryui.com/ticket/6676? |
Well, it's 3 years, and what has been changed since then is that all Arabic countries except 3 countries starts their workweeks on Sunday. So, we should go with the majority and make the firstDay variable = 0 until you use the CLDR and have a specific locale for each country. |
Have a look over this page http://en.wikipedia.org/wiki/Workweek_and_weekend |
We'll land this for 1.12.0. |
We're ready to land this, but you signed the CLA with a different email address than the one you used in git. Please let us know which address you want to use. If it's the one in git, you'll need to sign the CLA again. |
Sorry, I missed that. I'll go with the one I use on GitHub.I'll try to sign the CLA within hours. —Mohammed Alshehri On Tue, Oct 21, 2014 at 9:33 PM, Scott González notifications@github.com
|
You signed with the same email address you signed with last time. Is that the address you want to use? You have git configured to use Gmail. |
I'm sorry I did that again :) I've just signed using the same email I use for Github. I think it's ok now. |
Well, now you've signed three times with the same email address. I'm going to use that addres and change the commit info. |
Fixes #10035