Datepicker: reject dates with two year digits when expecting 'yy' #1248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @rclmenezes. Can you please sign our CLA so we can review this? Thanks. |
|
Done. Thanks! |
|
So what's the next step for a pull request like this? |
|
Hi @rclmenezes, I apologize for the delay on this. We're in the process of rewriting datepicker so we're hesitant to land any changes to the existing widget. That being said, this is pretty straightforward, and this ticket has come up more than once. I also verified this patch works as expected. |
|
No worries - thanks for letting me know! On Mon, Jul 14, 2014 at 9:35 AM, TJ VanToll notifications@github.com
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
parseDate accepts dates with two year digits when using formats like 'mm/dd/yy'. With 'yy', it should only accept years with four digits.
Fixes #8353