Conversation
Fixes #10082
|
Not sure if this is really an issue or not but this causes the menu to close when you zoom in or out. |
|
@arschmitz Do you mean on mobile? I'm not seeing that behavior on desktop browsers. This looks good to me. |
|
Actually I take that back. I just played with this change on a few mobile devices and the behavior is actually a bit annoying. If the menu doesn't quite fit in the viewport of the device, or you just want to zoom in to make sure you click the correct option, when you complete your pinch to zoom the browser fires a |
|
@tjvantoll yes on mobile and yes very annoying |
|
@tjvantoll @scottgonzalez What we do in mobile is just hide the menu while scrolling and or resizing the window. We then reposition it once scrolling or resizing has stopped. |
|
Closing this for now. |
Fixes #10082
scrollevents don't bubble, so we need to bind directly to all ancestors. We should take the same approach for other widgets with popups.