Fix problems with content async ajax request #1272
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were 2 problems, first af all, the check for "ui-tooltip-open" was done -before- the _delay call. This means that when the _open function was actually called, the user could have already moved his mouse out. I've moved the check to the start of the _open function because I believe that's where it should actually always be checked. Second, the mouseout events were only set in the _open function. This way, with the async ajax request, the mouseout events were never called when the tooltip wasn't actually opened (the user moved the mouse away before the content was able to update). I've set the events in the open function now as well.
|
Hi @lotjuh, Thanks for taking the time to contribute to jQuery UI. We have the following requirements of pull requests before we can review them.
I'm going to close this for now, but feel free to send another PR after addressing these points. You might also want to check out #1053, which is another pending PR that addresses this issue. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were 2 problems, first af all, the check for "ui-tooltip-open" was done -before- the _delay call. This means that when the _open function was actually called, the user could have already moved his mouse out.
I've moved the check to the start of the _open function because I believe that's where it should actually always be checked.
Second, the mouseout events were only set in the _open function. This way, with the async ajax request, the mouseout events were never called when the tooltip wasn't actually opened (the user moved the mouse away before the content was able to update). I've set the events in the open function now as well.
Should fix #8740