Skip to content

Droppable: Fixes: Ticket #10111.#1273

Closed
Mdonmounts wants to merge 1 commit into
jquery:masterfrom
Mdonmounts:master
Closed

Droppable: Fixes: Ticket #10111.#1273
Mdonmounts wants to merge 1 commit into
jquery:masterfrom
Mdonmounts:master

Conversation

@Mdonmounts
Copy link
Copy Markdown

Clear greedy children when a draggable is dropped on a target droppable.

Clear greedy children when a draggable is dropped on a target droppable.
@Mdonmounts
Copy link
Copy Markdown
Author

Link to issue: http://bugs.jqueryui.com/ticket/10111

@scottgonzalez
Copy link
Copy Markdown
Member

@Mdonmounts Can you please sign the CLA and add a unit test?

@scottgonzalez
Copy link
Copy Markdown
Member

Closing due to inactivity.

@Mdonmounts
Copy link
Copy Markdown
Author

Sorry, don't really use Github so I didn't see this til now. I have signed the CLA and am trying to add a unit test now. Hold pleas.

@Mdonmounts
Copy link
Copy Markdown
Author

Also, could anyone point me at tests that actual tests functionality like this at the moment? As far as I can tell, some of the droppable tests do nothing (shouldDrop and shouldNotDrop just return 'ok'). I see some draggable stuff in there that I'm trying to follow/use to get the testing I need in.

@scottgonzalez
Copy link
Copy Markdown
Member

Take a look at tests/unit/droppable/options.js.

@atkeranov
Copy link
Copy Markdown

So 4 years later people are still forced to fix this on their own inside the jquery-ui code?

scottgonzalez commented on May 6, 2015
Closing due to inactivity.

Well played!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants