Tests: Use closeEnough() to account for rounding differences #1275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Selectmenu's test suite broke with b0e8380, which changed the padding used by the menu widget. Selectmenu conditionally adds pixels to the menu's width, and using closeEnough() accounts for that and the rounding differences across browsers.
|
Sounds fine to me. We spend a lot of time with these off-by-one issues in tests that never seem to be an actual problem, so using |
|
Yeah. I should also mention that I verified that the widget's look fine in all of our supported browsers. It's just the tests. |
|
I able to confirm this was only a problem in the unit tests. The mentioned |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I looked into the failing test that was caused by b0e8380. At the moment, the failing test is fragile in that it is dependent on the
padding-lefton.ui-menu .ui-menu-item. If you play with that value (which is currently1em) you can get the tests to pass and fail in various browsers. The previous value of.4emjust happened to work. Some other values like.9emjust happen to work as well.1emdoesn't, so tests are currently failing.In addition to the rounding differences, there's also this check that conditionally adds a pixel to the menu's width. If I comment out that check the tests pass with the current padding, but I assume the check is necessary.
The rounding error and the conditional check each have the ability to throw the test off by a pixel, therefore I switched the test to use
closeEnough()to account for this. It's not ideal, but I can't think of a better way of handling this.cc @fnagel, @jzaefferer, @tcrowley