Skip to content

Draggable: Only apply ui-draggable-handle within the draggable instance #1284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

tjvantoll
Copy link
Member

Fixes #10212

@@ -314,8 +314,10 @@ $.widget("ui.draggable", $.ui.mouse, {
},

_setHandleClassName: function() {
var handle = this.options.handle ?
$( this.options.handle, this.element ) : this.element;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use this.element.find( this.options.handle ).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@@ -314,8 +314,10 @@ $.widget("ui.draggable", $.ui.mouse, {
},

_setHandleClassName: function() {
var handle = this.options.handle ?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should store this as this.handle and use that inside _removeHandleClassName() to ensure we don't break nested draggables.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in a new commit. This actually cleaned up the code some too.

@scottgonzalez
Copy link
Member

Looks good.

@tjvantoll tjvantoll closed this in 7594a31 Jul 15, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants