Skip to content

Selectmenu: Properly set width for button #1296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

scottgonzalez
Copy link
Member

Fixes #10145

I'm not sure why this test fails. I put the exact same code in a demo and it worked properly.

@tjvantoll
Copy link
Member

The test doesn't work because the <select> in question already has a selectmenu instance associated with it. If you chain a selectmenu( "destroy" ) call before the selectmenu() one the test passes.

@scottgonzalez
Copy link
Member Author

Ah, right. I thought I was using a different select than the other tests, but I ended up using the same one. This can be simplified a bit then :-)

@scottgonzalez
Copy link
Member Author

updated

@tjvantoll
Copy link
Member

You apparently commit faster than I type.

Besides that this seems fine. I hate having to show something to get its dimensions, but I don't think we have another choice here.

btw the second assertion in this test is the one that currently fails in IE 9–11, just in case looking into this has given you some insights into that mystery :)

@scottgonzalez
Copy link
Member Author

Ok, I'll land this now and then try to figure out the existing failure.

@scottgonzalez scottgonzalez deleted the selectmenu-width branch February 24, 2015 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants