Still tooltip animation effects #130
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
http://wiki.jqueryui.com/w/page/12138112/Tooltip http://bugs.jqueryui.com/ticket/3772 Fixed: #3772 - work through places where animations could be used this time solution based on both my previous pull requests: - added new method to tooltip object "_animate", that is based on kbwood animation solution posted http://bugs.jqueryui.com/ticket/3772#comment:6 - default animations fadeIn / fadeOut implemented, thank's Jörn) - And some from Jörn: "Somewhat related: With this API implemented, the close callback could run once the animation is completed, instead of as soon as the animation starts. Though that could get into trouble when the closing animation is cancelled (hover before animation finished)." So may be fire trigger close event just before animation fired?
|
second commit just to remove old messy comments P.S. |
|
Tooltip animations can't use standard effects because we need to be able to stop the animation in the middle and start the opposite animation. This can easily be handled with a fade to 0 and 1, but can't be easily applied to anything else. Until we have a solution for that problem, we can't land any additional animation options. |
|
Thanks, now i see |
|
PS: I just pushed an update to the tooltip implementation that gets rid of the need to use .stop() at all. So customizing animations should be a lot easier now. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for issues described
there http://wiki.jqueryui.com/w/page/12138112/Tooltip
and there http://bugs.jqueryui.com/ticket/3772