Build: Update jscs and fix some code style issues#1311
Merged
jzaefferer merged 1 commit intojquery:masterfrom Aug 14, 2014
jzaefferer:grunt-jscs-update
Merged
Build: Update jscs and fix some code style issues#1311jzaefferer merged 1 commit intojquery:masterfrom jzaefferer:grunt-jscs-update
jzaefferer merged 1 commit intojquery:masterfrom
jzaefferer:grunt-jscs-update
Conversation
Member
|
Looks good. We might want to create a ticket to address |
Member
|
👍 |
Disables the checks for casing and line length, since those need a lot more effort to address. For variable naming the fix isn't obvious to me. There's way too many lines over 100 chars.
Member
Author
|
Landed this and created a follow-up ticket: http://bugs.jqueryui.com/ticket/10545 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disables the checks for casing and line length, since those need a lot more effort to address. For variable naming the fix isn't obvious to me. There's way too many lines over 100 chars.
Removing the two overrides results in 186 code style errors. Breaking lines above 100 chars is just work, but fixing the variable naming isn't straightforward. For example, what do we do with
widget_sliceinwidget.js?Let's land this as-is and fix the rest later, it'll help in other branches as well.