Skip to content

Draggable: Ensure helper is positioned even if its the element itself#1313

Closed
mikesherov wants to merge 1 commit into
jquery:masterfrom
mikesherov:t9446
Closed

Draggable: Ensure helper is positioned even if its the element itself#1313
mikesherov wants to merge 1 commit into
jquery:masterfrom
mikesherov:t9446

Conversation

@mikesherov
Copy link
Copy Markdown
Member

No description provided.

@mikesherov
Copy link
Copy Markdown
Member Author

I opened this PR because @scottgonzalez seemed lukewarm on fixing this in the bug tracker ticket. @scottgonzalez any thoughts now that you know what the fix is?

@scottgonzalez
Copy link
Copy Markdown
Member

My biggest concern at this point would be either complicating the code in the new implementation or changing behavior in the new implementation. Can you look at what happens in this case in the interactions branch? Whether it works or not, I'm fairly sure the element is going to be forced to absolute positioning because this is a really odd scenario.

@mikesherov
Copy link
Copy Markdown
Member Author

Yeah, I'll discuss this with @DaveStein to see what impact this has on the new code, which by the way, he's made tremendous progress on in the past few weeks.

The new draggable doesn't always use absolute, so I think its a trivial change there but will double check.

@mikesherov
Copy link
Copy Markdown
Member Author

Yeah, fix is as trivial in the new code. @scottgonzalez I'm going to land this.

Comment thread tests/draggable.html
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing newline

@mikesherov
Copy link
Copy Markdown
Member Author

Landed in 451dded

@mikesherov mikesherov closed this Aug 19, 2014
@mikesherov mikesherov deleted the t9446 branch August 22, 2014 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants