Avoid memory leak with event bindings #1319
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| this.headers = this.element.find( this.options.header ) | ||
| .addClass( "ui-accordion-header ui-state-default ui-corner-all" ); | ||
|
|
||
| this.headers.next() | ||
| this.panels = this.headers.next() |
There was a problem hiding this comment.
Is there a need to assign this to this.panels? Curious because it wasn't done before.
There was a problem hiding this comment.
Yes, so that we can get the previous value during a refresh.
|
👍 |
scottgonzalez
added a commit
that referenced
this pull request
Aug 21, 2014
scottgonzalez
added a commit
that referenced
this pull request
Aug 21, 2014
Fixes #10056 Ref gh-1319
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes http://bugs.jqueryui.com/ticket/10056
Original discussion in #1288
The following widgets have
refresh()methods:._on(), so has no leak.