Draggable: Whitespace and naming cleanup of connectToSortable #1323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| item: inst.element | ||
| }); | ||
| item: draggable.element | ||
| }); |
There was a problem hiding this comment.
It could just be the diff, but this looks like it's indented too much.
There was a problem hiding this comment.
Github now turns tabs into 8 spaces. This is indented one extra time from the var. incorrect?
There was a problem hiding this comment.
With a single variable, we don't do the extra level of indentation, which I realize is strange.
var foo = {
a: "b"
};
var foo = {
a: "b",
},
bar = {};
I don't think we've ever been clear about this in the style guide.
Since a sortable grows or shrinks when a draggable element is added to it, refresh the cached positions of sortables whenever an element is added or removed from the sortable. Refs #9675
faf0682 to
46f1af3
Compare
46f1af3 to
bc5cd92
Compare
Refs #9481 Refs #9675 Closes jquerygh-1323
bc5cd92 to
bfb6507
Compare
| inst.cancelHelperRemoval = true; //Don't remove the helper in the draggable instance | ||
| this.instance.cancelHelperRemoval = false; //Remove it in the sortable instance (so sortable plugins like revert still work) | ||
| if ( sortable.isOver ) { | ||
| sortable.isOver = 0; |
There was a problem hiding this comment.
While you're cleaning this up would it be possible to change isOver to be a boolean rather than a 0 or 1?
There was a problem hiding this comment.
I'll do that in a followup. Good catch.
|
Ah I missed that you merged this. Nevertheless this looks good. |
mikesherov
added a commit
that referenced
this pull request
Oct 15, 2014
Refs #9481 Refs #9675 Closes gh-1323
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.