Skip to content

Resizable: alsoResize more than one element of a jQuery selection #1324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Resizable: alsoResize more than one element of a jQuery selection #1324

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c1fbeb9
Resizable: alsoResize more than one element of a jQuery selection
benmosher Aug 25, 2014
6ec45fc
Resizable: unit test for multi-element-selection alsoResize.
benmosher Aug 28, 2014
f3a3ad3
Resizable: unit test typo (missing comma). 😳
benmosher Aug 28, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions tests/unit/resizable/resizable_options.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -404,4 +404,34 @@ test( "alsoResize + containment", function() {
equal( other.height(), 150, "alsoResize constrained height at containment edge" );
});

test( "alsoResize + multiple selection", function() {
expect( 6 );
var other1 = $( "<div>" )
.addClass("other")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spacing

.css({
width: 50,
height: 50
})
.appendTo( "body" ),
other2 = $( "<div>" )
.addClass("other")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spacing

.css({
width: 50,
height: 50
})
.appendTo( "body"),
element = $( "#resizable1" ).resizable({
alsoResize: $.merge(other1, other2),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other1.add( other2 )

containment: "#container"
});

TestHelpers.resizable.drag( ".ui-resizable-se", 400, 400 );
equal( element.width(), 300, "resizable constrained width at containment edge" );
equal( element.height(), 200, "resizable constrained height at containment edge" );
equal( other1.width(), 250, "alsoResize o1 constrained width at containment edge" );
equal( other1.height(), 150, "alsoResize o1 constrained height at containment edge" );
equal( other2.width(), 250, "alsoResize o2 constrained width at containment edge" );
equal( other2.height(), 150, "alsoResize o2 constrained height at containment edge" );
});

})(jQuery);
23 changes: 2 additions & 21 deletions ui/resizable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -994,19 +994,7 @@ $.ui.plugin.add("resizable", "alsoResize", {
});
});
};

if (typeof(o.alsoResize) === "object" && !o.alsoResize.parentNode) {
if (o.alsoResize.length) {
o.alsoResize = o.alsoResize[0];
_store(o.alsoResize);
} else {
$.each(o.alsoResize, function(exp) {
_store(exp);
});
}
} else {
_store(o.alsoResize);
}
_store(o.alsoResize);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can also be inlined instead of having a function now.

},

resize: function(event, ui) {
Expand Down Expand Up @@ -1040,14 +1028,7 @@ $.ui.plugin.add("resizable", "alsoResize", {
el.css(style);
});
};

if (typeof(o.alsoResize) === "object" && !o.alsoResize.nodeType) {
$.each(o.alsoResize, function(exp, c) {
_alsoResize(exp, c);
});
} else {
_alsoResize(o.alsoResize);
}
_alsoResize(o.alsoResize);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The function call is no longer needed since there's a single path. Just do the looping directly. The logic inside the loop should also be cleaned up since there are no longer any contexts provided for the searching.

},

stop: function() {
Expand Down