Theme: disabled elements can still be focused with a click #1330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pointer-events: none; fixes this in chrome, safari, and firefox ie and opera both show no focus styles on click so lack of pointer-events support in old ie is not a problem. Fixes #10573
Member
|
Looks good. |
Member
|
Looks good, except for the lack of punctuation in the commit message (same as the PR text). |
Member
Author
|
@jzaefferer @scottgonzalez Ill fix that and land this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pointer-events: none; fixes this in chrome, safari, and firefox
ie and opera both show no focus styles on click so lack of
pointer-events support in old ie is not a problem.
Fixes #10573