Skip to content

Button Re-write#1332

Closed
arschmitz wants to merge 28 commits intojquery:masterfrom
arschmitz:button
Closed

Button Re-write#1332
arschmitz wants to merge 28 commits intojquery:masterfrom
arschmitz:button

Conversation

@arschmitz
Copy link
Member

@arschmitz arschmitz commented Sep 2, 2014

This replaces PR #1216

This includes new widget controlgroup which replaces buttonset
Current known issues

  • Accordion Test Failures due to focus not working in phantom
  • Checkboxradio testfailure missing default element (@scott_gonzalez said it should not have one because it cant be sane ) this causes common tests to fail
  • Backcompat
  • Controlgroup icon only buttons 1px too short in chrome, firefox extra weird @jaspermdegroot think you could take a look?

arschmitz added 19 commits August 20, 2014 19:00
@arschmitz
Button: Inital commit of button refactor
ebea476 
Move to using element stats rather then js class states remove
ui-button-text spans.
Removed button set
@arschmitz
button: pr update
94eaa1f
@arschmitz
Button: comment out test thats failing only in phantom
82ddb7a 
Until i can figure out why so this will pass on travis
@arschmitz
Button: Update disabled logic to simplify
fd4ed63
@arschmitz
Button: move button icon position classes out of core
8b91839
@arschmitz
Button: Move all dom minipulation in _create into its own method
cb5bfb4 
This is to support easy implementation of mobiles enhanced option
@arschmitz
Button: remove outdated demos
84fa3ad
@arschmitz
Button: fix css broken from rebase
70c8d3b
@arschmitz
Dialog: Updating dialog and tests for new button API
792aa05
@arschmitz
Selectmenu: update to use button css
b785f83 
This ensures consistency between different form elements
@arschmitz
Accordion: update to use button css
36aa43a
@arschmitz
Checkboxradio: inital commit of new widget
4f1e2ba
@arschmitz
Checkboxradio: Updates based on pr comments
a82ff60
@arschmitz
Checkboxradio: add visual focus outline to checkbox and radio buttons
4f792bb 
This adds a focus outline matching that roughly from chrome osx
@arschmitz
Checkboxradio: allow the parent of the input to be the label
6dcea08 
Conflicts:
	ui/checkboxradio.js
@arschmitz
Controlgroup: Inital commit of new widget
a736b22 
This widget replaces the buttonset widget
@arschmitz
Button: fix css errors
c40020d
@arschmitz
Fixup: this commit needs to be split up it is html and css lint issues
f676f07
@arschmitz
Controlgroup: Updating last refrences from buttonset to controlgroup
d04e1e7
@arschmitz arschmitz changed the title Button Button Re-write Sep 2, 2014
@arschmitz arschmitz mentioned this pull request Sep 2, 2014
Closed
jzaefferer
jzaefferer reviewed Sep 2, 2014
View reviewed changes
ui/button.js
Copy link
Member

@jzaefferer jzaefferer Sep 2, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no reason for this being here. Return value is never used. Remove?

@jzaefferer
Copy link
Member

jzaefferer commented Sep 2, 2014

  • Update demos/button/index.html
  • demos/button/default.html: No active style with mouse or keyboard interaction (click, return/space press). Nor anywhere else, prevents testing anything properly.
  • demos/button/icons.html still looks like a visual test, not a demo
  • demos/index.html is missing checkboxradio and controlgroup
  • demos/checkboxradio is missing index.html
  • demos/checkboxradio/default.html doesn't have the "command line" anymore, but still doesn't look like a demo. Labels should reflect some real world usecase.
  • demos/checkboxradio/icon.html Rename to icons.html. Also update labels as in default demo (previous item)
  • demos/controlgroup is missing index.html
  • demos/controlgroup/default.html As above, labels should demo something
  • demos/controlgroup/toolbar.html now that's a demo! I don't think it needs as much text content, "Part I" should be more than enough. Demo description needs an update, doesn't do this justice.
  • tests/visual/index.html is missing checkboxradio

@arschmitz arschmitz closed this Sep 2, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@arschmitz @jzaefferer