Skip to content

Calendar rebase (2) #1351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fnagel wants to merge 53 commits into from
Closed

Calendar rebase (2) #1351

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
53 commits
Select commit Hold shift + click to select a range
7817898
Datepicker: Initial commit of widget rewrite work from old branch
tjvantoll Aug 26, 2013
f83580c
Datepicker: Update tests and demos for new structure
tjvantoll Aug 30, 2013
7a8de82
Datepicker: Fix the `eachDay` option
jzaefferer Sep 11, 2013
a6e1586
Datepicker: Only apply the `ui-state-focus` class name to one cell
tjvantoll Oct 30, 2013
3ec7d0e
Datepicker: Clean up tests
tjvantoll Nov 2, 2013
059f277
Datepicker: Support changing the `appendTo` option after init
tjvantoll Nov 15, 2013
0f66c9a
Datepicker: Various changes for the `showWeek` option
tjvantoll Nov 15, 2013
0b5703e
Datepicker: Support `position` option changes after init
tjvantoll Nov 18, 2013
33c48bd
Datepicker: Support changing `eachDay` after initialization
tjvantoll Nov 19, 2013
acf329d
Datepicker: Allow `dateFormat` to be changed after init
tjvantoll Nov 20, 2013
6458bab
Datepicker: Add test to ensure the `<input>`'s value is preselected
tjvantoll Nov 20, 2013
c8c44d4
Datepicker: Support destroying inline datepickers
tjvantoll Nov 22, 2013
ae29574
Datepicker: Add `value()` and `valueAsDate()` methods
tjvantoll Nov 21, 2013
e143e5b
Datepicker: Fix key handling implementation and tests
tjvantoll Nov 22, 2013
7e39bc1
Datepicker: Use Globalize 1.0.0
rxaviers Nov 30, 2013
4d51220
Datepicker: Update key handling implementation and tests
tjvantoll Dec 27, 2013
4db03f4
Datepicker: Re-adding mouse tests
tjvantoll Jan 2, 2014
07a5814
Datepicker: Add an `isValid()` method
tjvantoll Jan 3, 2014
3a38e81
Datepicker: Handle invalid values in `value()` and `valueAsDate()`
tjvantoll Jan 3, 2014
6c0a1c3
Datepicker: Update the picker as the user types valid dates
tjvantoll Jan 3, 2014
24110f2
Date: Update test suite to coding standards
tjvantoll Jan 9, 2014
8a115dc
Date: Make `$.date()` a constructor function
tjvantoll Jan 9, 2014
50447d2
Datepicker: Fix code style issues
fnagel Apr 23, 2014
88f4a15
Datepicker: Rename `select()` method to `_select()`
fnagel Apr 26, 2014
e8ea5f4
Datepicker: Use `short` instead of `abbreviated` format for table header
fnagel Apr 26, 2014
fb8d50d
Datepicker: Properly define default for `dateFormat` option
fnagel Apr 26, 2014
38f9989
Datepicker: Fix populate alternate field demo
fnagel Apr 26, 2014
4009361
Datepicker: Fix icon trigger demo
fnagel Apr 26, 2014
62922fe
Datepicker: Introduce value option
fnagel May 15, 2014
cf055ed
Calendar: Add calendar widget
fnagel Jun 3, 2014
daded42
Calendar: Add min and max option.
fnagel Jun 4, 2014
217bdc8
Calendar: Remove select callback reference
fnagel Jun 4, 2014
12090f3
Datepicker: Code clean up for events
fnagel Jun 5, 2014
31f9bd7
Datepicker: Remove unwanted keyboard shortcut
fnagel Jun 5, 2014
9b53f07
Datepicker: Simplify usage of calendar options and avoid duplications
fnagel Jun 12, 2014
088b7a4
Datepicker tests: Add open and close unit tests
fnagel Jun 16, 2014
7a9f5f4
Datepicker: Improve document click event
fnagel Jun 17, 2014
54d6f50
Calendar: Fix broken day table cell attributes
fnagel Jun 17, 2014
2b2871b
Datepicker tests: Rewrite event unit tests
fnagel Jun 17, 2014
d743e21
Calendar: Fix multiple calendar styles
fnagel Jun 17, 2014
e71122c
Calendar: Fix German localization
fnagel Jun 17, 2014
84c1a87
Datepicker: Fix localization demo
fnagel Jun 18, 2014
2407e59
Datepicker: Several minor code improvements
fnagel Jun 18, 2014
fc87a82
Calendar: Fix hover event setting and removing
fnagel Jun 18, 2014
7edd77b
Calendar: Focus class is not removed when using arrow keys
fnagel Jun 19, 2014
a86d5b0
Datepicker: Remove unwanted CTRL+HOME shortcut
fnagel Jun 19, 2014
7a4fa37
Datepicker: Remove support for enter key on input
fnagel Jun 19, 2014
1b27113
Datepicker: Improve localization handling, code style
fnagel Jun 19, 2014
b0877b1
Calendar: Add buttons option
fnagel Jun 19, 2014
2cbd500
Calendar: Adjust files to match reorganization of external directory
fnagel Jul 2, 2014
a4c2033
Datepicker tests: Remove pass-through options unit tests
fnagel Aug 29, 2014
97ce362
Calendar: Use _on for link hover events
fnagel Aug 30, 2014
d364a89
Datepicker: Add missing handling for disabled option
fnagel Sep 1, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Calendar: Remove select callback reference
  • Loading branch information
@fnagel
fnagel committed Sep 29, 2014
commit 217bdc80148b3f9cbb6969e10be7fdd354a2e783
5 changes: 1 addition & 4 deletions ui/calendar.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -420,10 +420,7 @@ return $.widget( "ui.calendar", {

_select: function( event, time ) {
this._setOption( "value", new Date( time ) );
this._trigger( "select", event, {
// TODO Replace with value option to initialise and read
date: this.value()
});
this._trigger( "select", event );
},

value: function( value ) {
Expand Down
6 changes: 3 additions & 3 deletions ui/datepicker.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,11 +91,11 @@ $.widget( "ui.datepicker", {
numberOfMonths: this.options.numberOfMonths,
showWeek: this.options.showWeek,
value: this._getParsedValue(),
select: function( event, data ) {
that.element.val( data.date );
select: function( event ) {
that.element.val( that.calendarInstance.value() );
that.close();
that._focusTrigger();
that._trigger( "select", event, data);
that._trigger( "select", event );
}
})
.calendar( "instance" );
Expand Down