Skip to content

Conversation

@tjvantoll
Copy link
Member

Closes gh-1355

@scottgonzalez
Copy link
Member

This looks good. I traced back to where this check came from to see if there was a reason 1 was used, but it just lead to a several year old copy from an old branch: 3d5adba

@jzaefferer
Copy link
Member

Well, I wrote that piece originally. I can't tell why it did that kind of checks, but this works well.

One thing that doesn't work and probably never worked since it was added in 9e617bb is the typeahead on the menu with custom markup and multi-line items. Since the typeahead uses .text() to get the text of each item and compare it to the pressed characters, I don't see why its not working.

@scottgonzalez
Copy link
Member

If you put together a fiddle showing the broken broken behavior, I can look into it at some point.

@jzaefferer
Copy link
Member

On http://view.jqueryui.com/master/tests/visual/menu/menu.html, tab until focus is on "Menu with custom markup, multi-line items and a custom submenu icon", then type "j" repeatedly (or some other character). Focus should move around, instead nothing happens.

@tjvantoll tjvantoll merged commit 29c72fc into jquery:master Oct 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants