Ticket #4386 Fix enable and disable methods when index is undefined. #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…les are stacked in a range
…on.y options and make the slider use _mouseStart rather than _mouseCapture to respect _mouseDistanceMet
…s undefined. Fixes #4386
* 'master' of git://github.com/jquery/jquery-ui: (65 commits) Tooltip: Make sure we have a target before trying to open the tooltip. Tooltip: Rename _show to _open. Widget tests: Work around a bug in jQuery core in IE 9rc. Spinner: Ignore delta of 0 from triggered mousewheel event. Verified that mousewheel scrolling actually works fine in IE6. Accordion: Improve unit test to get consistent results on mobile devices Position: Test for window scrollTop support and run scrolled window test only when support is there. Should exclude mobile devices, getting the position testsuite to produce more useful results. Button: Only add text classes if there is text. Fixes #7040 - button class change breaks icon only buttons. Autocomplete: Update combobox menu to point out limits and link to explaining it. Menu: Cleanup contextmenu demo and fix aria unit test to ignore empty string values Adding a domEqual assertion to our testsuite for more sane DOM comparisons. Comparing innerHTML is too dependent on random browser quirks like IE only sometimes rendering closing tags. Position: Drop offset-as-a-setter from position, 1.9 won't support core 1.3 anymore Menu: Cleanup unit test page Datepicker: Added Tajikistan localization. Fixes #7034 - Datepicker: Add Tajikistan localization. Menu: Optimize menu positioning in menubar Menu: Add ui-state-active to active menu bar button Autocomplete tests: Fixed various bugs in various versions of IE. Added two options to set the button style and add down arrow icons Added a second example to show a menubar with buttons and icons and one without (default) Menu: Fix testsuite, new option Removed active state when menu closes ...
|
Can you rebase this or just reapply the patches as a single commit? I think when you fully disable the tabs, the selected tab to should be disabled as well. There's currently code special casing the selected tab. Was there a specific reason for that? In the tests, when you enable/disable the tabs individually, can you test the state between each action? I understand why you didn't add assertions for that since the tests were specifically for fully enabled and fully disabled. If individual enabling and disabling is already tested somewhere else, then the tests can stay as they are. Thanks. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.tabs("disable") and .tabs("enable") doesn't work. This change fixes the 2 methods so that when index is undefined it disables/enables all tabs (expect for the current selected tab). It also sets option.disabled to true/false when the tabs are fully enabled/disabled.
Also added some tests for this.
http://bugs.jqueryui.com/ticket/4386